Commit message problem with IBM Rational Rhapsody and external svn 1.7 tools

[TimoS]

Hi!
I'm evaluating AgentSVN 2.47 as PushOK replacement for Rational Rhapsody in my company.
As we are using SVN 1.7 I use TortoiseSVN in an appropriate version (TortoiseSVN 1.7.13, 64 Bit / Subversion 1.7.10), I configured AgentSVN to not use the internal svn tools.

If I try to commit changed files from Rhapsody, nothing really happens. I looked into the log file and I think I found the problem:

Code: Select all

[Mon Aug 10 16:14:31 2015] >> *   Command: svn.exe --non-interactive --trust-server-cert commit --no-unlock  -m""My commit message

""  --changelist CL-25962575

Two lines later in the log file SVN tells me this:

Code: Select all

[Mon Aug 10 16:14:32 2015] >>    svn.exe: invalid option: 

It seems that the quotation marks around the commit message (see string above "My commit message") are wrong. I can clearly reproduce this in the shell. If I change the quotation marks in this way, the commit works fine:

Code: Select all

svn.exe --non-interactive --trust-server-cert commit --no-unlock  -m "My submit message"  --changelist CL-25962575

Also I'm not sure if these newlines in the log file are caused by the logging itself or from AgentSVN, which would mean that AgentSVN trys to execute three commands instead of one (first the svn command, then only carriage return, and the third one is "" --changelist CL-25962575). May be this is another bug.

Could you please fix this issue?

Best regards
Timo Steuerwald

[jussij]

Hi Timo,

Thank you for posting what is an extremely detailed bug report

I definitely looks like you have found an bug in Agent SVN

Could you please fix this issue?

Looking at the log file output you have posted I can see this:

-m""My commit message

""

So the bug looks like the user message was not filtered correctly by Agent SVN.

When you did the commit did you type something like this as the message (i.e. include the quotes):

"My commit message"

The issue is the quotes are not needed as Agent SVN will add those quotes, and in this case has added them twice, which caused the problem.

If instead you had just entered this as the comment then I am sure the commit will have worked as expected:

My commit message

I'm not sure where the carriage return line feed has come from but that should also be fixed in Agent SVN.

I will make sure Agent SVN is fixed to look out for this type of user input and filter it accordingly.

But in the mean time if you enter the comment without quotes then Agent SVN should work as expected.

Cheers Jussi

[TimoS]

Hi Jussi!
Thank you for your really fast answer!
I committed this change without adding quotation marks to the commit message. I'm not sure if adding quotation marks manually will already fix the issue, I think there should be also a space between -m and the commit message itself or am I wrong?
May be I should add a space in the edit field where I put the commit message as first? Like this: <space>"My commit message"
I will try this as soon as I have something new to submit.
Keep up the good work!

Cheers
Timo

[jussij]

Thank you for your really fast answer.

Thank you for taking the time to post the bug report. This was definitely a hidden bug in Agent SVN and it is always good to kill bugs

I'm not sure if adding quotation marks manually will already fix the issue.

The fix that will be added to Agent SVN is it will look out for those quotes marks and adjust the comment text as required.

So once that fix is made it will not matter if the user adds quotes or not. But for now just make sure you do not add any "quotes" to the message.

I think there should be also a space between -m and the commit message itself or am I wrong?

I works without the space but for readability the space is probably a good idea. I will make sure that change is also made.

May be I should add a space in the edit field where I put the commit message as first? Like this: <space>"My commit message"

There is no need. The -m"My commit message" will work just fine.

Let me know if it does not

Cheers Jussi

[jussij]

This comment issue has been fixed in the latest Agent SVN version.

The latest version of Agent SVN can be found here: http://www.zeusedit.com/agent/download.html

Cheers Jussi

[TimoS]

Hi Jussi!
I can confirm that this bug is fixed in version 2.48. After upgrading commit in Rhapsody works as expected!
Thank you for the prompt fix!

Cheers
Timo